![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
Was working from home.
Tom carefully reviewed my fix, and taught me to use avro-tools.jar, to produce a good sample avro file. So I mostly rolled back my adhock, produced the file, and everything's ok.
Eric, after two days of silence, wrote that he does not have time to review my 12 files. I wrote to him first that well, he could have told me earlier, and that we are supposed to do reviews, but then removed my comments. What's the point of talking to someone who does not care to listen.
At 11:15 there was a scrum meeting. I said that I have a queue of prs, but nobody wants to review. Indranil volunteered. Of course. Thanked him, added him to the list.
Oh, also he posted that pr with "smoke tests". He wrote them in python. Wow, wow. But it's ok.
Meanwhile, Josh suddenly volunteered to review my 12 files. Ok. Then he suggested to use uniform class naming, either `CSV` everywhere, or `Csv` everywhere. The standard is the latter. So I wrote, ok, let me rename it in a separate PR. Sent it to him, 25 files. Approved, merged. Then I started splitting those 12 files.
Because, well, people actually can't read other people's code. Some people can - like Qi, Rohit. Some not.
So that's how I spent my day. Pretty stupid, eh.
Tom carefully reviewed my fix, and taught me to use avro-tools.jar, to produce a good sample avro file. So I mostly rolled back my adhock, produced the file, and everything's ok.
Eric, after two days of silence, wrote that he does not have time to review my 12 files. I wrote to him first that well, he could have told me earlier, and that we are supposed to do reviews, but then removed my comments. What's the point of talking to someone who does not care to listen.
At 11:15 there was a scrum meeting. I said that I have a queue of prs, but nobody wants to review. Indranil volunteered. Of course. Thanked him, added him to the list.
Oh, also he posted that pr with "smoke tests". He wrote them in python. Wow, wow. But it's ok.
Meanwhile, Josh suddenly volunteered to review my 12 files. Ok. Then he suggested to use uniform class naming, either `CSV` everywhere, or `Csv` everywhere. The standard is the latter. So I wrote, ok, let me rename it in a separate PR. Sent it to him, 25 files. Approved, merged. Then I started splitting those 12 files.
Because, well, people actually can't read other people's code. Some people can - like Qi, Rohit. Some not.
So that's how I spent my day. Pretty stupid, eh.
